TrinityCore/TrinityCore — pull request #7776 by betagan (2012-09-15 13:21:52+00:00)
Title: correct removal of misdirection on player cancel aura (#4343)

See the bugreport: #4343

Short description: If player cancelled misdirection by rightclick on buff, script would not disable thread reduction because in that case, GetDuration() still returns non-zero. Thus the required RemoveMode check.

I dont take all credit for this fix, Kandera came up with the solution in https://github.com/TrinityCore/TrinityCore/issues/4343#issuecomment-5550157 but missed the GetDuration part. That way, the correct buff removal by attack broke as well.