ppi/framework — pull request #59 by syntaqx (2012-09-12 13:17:47+00:00)
Title: Quibbles

Mostly small stuff I've come across while looking over the code.

I'd like to hear your feedback on the pull request before you merge it in — I'm sure there's some things I missed during the initial sweeps, so it'll give me a bit of extra time to find them.

#### New Files

* `.gitattributes` - Enforce LF normalization
* `LICENSE` - It's good practice, and makes it blatantly obvious (I had to ask)

#### Specific Modifications

* `.gitignore` - Added useful documentation and sanity rules.
* `README.md` - Updated to the "newer" markdown style and added some sexy tidbits.
* `PPI/ServiceManager/ServiceLocatorAware.php` - Fixed some broken'ness.

#### Etc.

* Normalized syntactic formatting where inconsistencies occurred.
* Normalized docblock formatting.
* Added `@return void` where missing (needed by quite a few generators).
* Added missing documentation information where functionality was blatantly obvious.
* Added `@todo Add inline documentation.` notation where docblocks were missing.

And probably some other stuff I'm forgetting.. you can always look at the commits for a line-by-line.