tomahawk-player/tomahawk — pull request #121 by crabmanX (2012-09-12 15:41:17+00:00)
Title: add source logo to now playing area

This adds support for showing the resolver logo in the now playing area and fixes bug http://bugs.tomahawk-player.org/browse/TWK-707.

Examples:
- http://imgur.com/8ep8j
- http://imgur.com/c2UGk

The icon is retrieved from the resolver itself via the "icon" variable. Icons should be monochrome and must be provided by the resolver. See https://github.com/crabmanX/tomahawk-resolvers/commit/a585d9c30993b4648e26ec7bfba47860216d5dc6 for examples.

descisions that might need some discussion:
- size and position of the icon: I tried aligning it with the social and love buttons. This looks like the icon was for an action, aka "love via soundcloud" . Some icons (e.g. youtube) are very hard to fit in 20x20 pixels.
- color vs. monochrome: the bug report mentions rdio requiring their icon to be shown for playing from their service. I doubt they (and others insisting on their icon being visible) will be ok with showing a monochrome icon. Therefore the icon is provided by the resolver, so services that allow bw icons can use bw icons, those that dont can use colorful ones.
- avatar icons: are very hard to desaturate/convert to bw. If we really want to insist on bw icons only, we might just always show the fallback-avatar.

TODO:
- add a proper default icon.
- open track page in browser on button click

Since im new to c++ and tomahawk, id be really thankful for some feedback

crabman