Islandora/islandora_content_model_forms — pull request #37 by DannyJoris (2012-09-11 16:34:10+00:00)
Title: coder cleanup

Two alerts are still in:
ingest.form.inc
severity: criticalLine 307: Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)
eval('$label = $form_state[\'values\']' . $label_field . ';');

edit.form.inc
severity: criticalLine 158: Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)
eval('$label = $form_state[\'values\']' . $label_field . ';');

That's because $label_field has a value typically named ['label_field']. Changing the way that works is outside of the coder cleanup scope

Needs doxygen comments:
https://github.com/Islandora/islandora_content_model_forms/blob/7.x/islandora_content_model_forms.module#L355 (all following functions)