MarcosMeli/FileHelpers — pull request #3 by jamesmanning (2012-09-11 16:35:47+00:00)
Title: support for excel stopping only when row is empty

The existing behavior in ExcelStorage was to stop when the first cell of a row was empty. Unfortunately, in our use we have some input spreadsheets from our customers where the first cell is empty, but it's not an empty row.

This pull request adds a property to the ExcelStorage engine that allows changing this behavior that defines when to stop reading the rows from the file. Due to backwards compat concerns, instead of just changing the behavior outright, the default is still kept for just checking the first cell.

IMHO, when there is a major revision of FileHelpers (the 3.0 release, for instance, given that changing to 'entire row empty' should not break any reasonable use of the library (IOW, it seems very unlikely that users were leveraging this behavior to stop processing on rows that had data in cells other than the first column), this would likely be better to either remove the enum and always use the 'stop on full row empty' (better long-term due to reduced complexity and lines of code) or at least change the default over to 'full row empty' (more likely what new users of the library will want/expect).

Thanks!

NOTE: this pull request currently includes an extra commit that adds a ReSharper file (DotSettings), but I'm going to try to figure out how to remove that commit from this pull request and then make it a separate pull request.