Islandora/islandora — pull request #165 by DannyJoris (2012-09-10 20:47:01+00:00)
Title: coder cleanup

Did a coder cleanup based on the most strict warnings. The only line I kept for now is the following:

islandora.module
severity: minorLine 231: in most cases, replace the string function with the drupal_ equivalent string functions
$pid_namespace = substr($object->id, 0, strpos($object->id, ':') + 1); // Get the namespace (with colon)

Because the api documentation says that the php functions are much faster. I would still use the drupal functions if it wasn't for the critical location of the functions. They're in an access callback function that is used by almost half of the registered islandora paths.
http://api.drupal.org/api/drupal/includes%21unicode.inc/function/drupal_substr/7

The doxygen comments are overall pretty good, but some might need a little cleanup.