Jasig/uPortal — pull request #67 by drewwills (2012-09-08 00:39:11+00:00)
Title: UP-3284:  Re-working implementation of isGuest() to prevent all instance...

...s of RestrictedPerson from reporting that they are NOT guests, even when they are

Here's what I discovered about this issue...
- The portal framework uses an instance of RestrictedPerson (instead of PersonImpl) when it needs to represent someone who is not logged (such as in the User Manager)
- RestrictedPerson instances have no (null) security context
- The isGuest() method, as it was written, always replied that a user was NOT a guest in any case where the security context was null
- Consequently, even the 'guest' user was considered non-guest buy this test, and (therefore) by the authenticated_users PAGS group.

That last bit is especially annoying when you want to push a fragment to all users who are logged in.

I want to make a quick check on IRC to see if anyone knows of a reason this change will cause pain in some new & unforeseen way. (It touches long-standing logic.) After that, I still have to make the change to rel-4-0-patches.