MarkehMe/FactionsPlus — pull request #42 by basicsensei (2012-09-02 21:37:20+00:00)
Title: fix the code logic for respect power loss

basically, I removed the option respectFactionsWarZonePowerLossRules, and the current code is treating it as if it were always true. I did not see a reason why it being false were ever usable, and it would've complicated the code logic.

As it is now, when Factions plugin does powerloss to a player, then FP will also apply its extra powerloss(or gain). If Factions plugin does not powerloss then FP will also not powerloss(or gain). This is how respectFactionsWarZonePowerLossRules=true would've worked, except the way it was before it had no effect (unless it was set to false, due to some broken code logic, it would act then as if it were true, aka to cause respect u'd have to set it to false, and if it were false and FP was being used with Factions 1.7.x it would err on console due to missing fields - since the code only worked for Factions 1.6).

The codelogic (for this powerloss respect) now works without errors with both Factions 1.6 and 1.7

I did some preliminary testing and updated the card on trello. Unless I'm missing something, it should work as expected.