jonleighton/poltergeist — pull request #142 by ryanfields (2012-09-02 03:00:01+00:00)
Title: Modification to keyboard events to resolve issue #131

I modified the creation of the keyboard events to allow charCode and keyCode to be set. I tested these changes against the projects I have that depend on those properties. All of the tests in those projects passed.

All of the Poltergeist tests are still passing, though I had to tell Capybara to wait a little longer since PhantomJS starts up really slowly on my system for some reason.

I didn't add any new tests, since the effect of the changes happens entirely in Javascript and there doesn't appear to be any kind of testing harness in place to test the compiled JS in Poltergeist yet. I wish I had time to set one up for you, but I've got too many other demands on my time right now.

Let me know if you have any questions or concerns regarding this request. The changes were minor.