tekkub/Cork — pull request #70 by hughescr (2012-08-31 23:56:55+00:00)
Title: Changes for MoP

I've fixed a bunch of stuff in the core and various modules to get things working for MoP (5.0.4). I've only done Warrior so far, but I have a toon of every class, so I'll log the rest in tonight and fix whatever's changed for each. This is pretty close though probably; There might be one or two other class-specific things like with warrior vigilance, but they're probably mostly minor.

You might take a look at how I handled the GetNum{Raid|Party}Members() calls, since they're not just straight-up function renames in some cases they require particular interpretations on iterating through "party1..4" and "raid1..40" -- really it'd be handy if Blizz had a "group1..40" which would work for either parties or raids. One nice thing is that GetRaidRosterInfo() at least works for both parties and raids, so I used that where possible. I had to stick with "partyN" vs "raidN" in some cases because I didn't want to have to look into the self["party"..i] stuff in the main Cork table. That could be re-written probably to use "groupN" even if you can't use those strings as a unitid.