ci-bonfire/Bonfire — pull request #557 by sourcejedi (2012-08-30 11:49:33+00:00)
Title: When logging in, check the user isn't banned

The user settings page currently sets $user->banned, but the login is checking for a Site.Signin.Allow permission instead. (There used to be a "Banned" role, which I assume had no permissions at all). This was fallout from the big code drop back in Feb.

This pull request includes a migration. So make sure the number assigned to the migration is still free when you merge it. (Or do a local merge, rename the migration and use git commit --amend).

The migration removes Site.Signin.Allow. **If you apply the migration and then switch to an older branch, you will not be able to log in. I recommend backing up your database in advance with phpmyadmin or equivalent** - not with bonfire, because you wouldn't be able to login to bonfire to restore from the backup.

The auth library was getting a bit crufty. So in linux-kernel style there's a hundred-line cleanup before the relatively small fix. Also a couple more fixes to the user module, that'd been hanging around for a while.