omab/django-social-auth — pull request #453 by stefanw (2012-08-28 14:27:53+00:00)
Title: Override extra arguments with GET request parameters

I think it would be helpful if some parameters can be set per request (and not only via settings).

One of these parameters would be `display` for the Facebook login. A website may have multiple ways to trigger a Facebook login: one via popup and one via a full page login.

This can be set globally via the settings:

FACEBOOK_AUTH_EXTRA_ARGUMENTS = {'display': 'popup'}

But currently this cannot be customized per request.

This pull request allows GET parameters to override extra arguments, but only those that are already present in `*_AUTH_EXTRA_ARGUMENTS`. So if you want to be able to override specific arguments, you have to put them in this setting.

This makes the auth flow more customizable and the app much more flexible.