roundcube/roundcubemail — pull request #22 by dfwarden (2012-08-28 17:23:49+00:00)
Title: Lighttpd mod_uploadprogress Support

APC upload progress does not working with fast-cgi: https://bugs.php.net/bug.php?id=58146

Lighttpd has mod_uploadprogress (which does work with fast-cgi) natively in 1.5.x and a patch is available for 1.4.x: http://redmine.lighttpd.net/projects/1/wiki/Docs_ModUploadProgress

This pull request adds a new configuration variable 'upload_progress_url_lighttpd' to Roundcube which, when set to non-null, will switch the upload progress system from APC to lighttpd if file upload progress is enabled. It also enables upload progress in general for "filedrop" or "drag-n-drop" uploads as well as checking the size of "filedrop" files before the upload starts.

I tried to conform to the code conventions wherever I could discern them. I briefly considered making this a plugin but it didn't seem to be possible to accomplish this using just the plugin hooks. I could be wrong about that. Suggestions/corrections/followup requests are very welcome.

I tested this on Oracle Enterprise Linux (RHEL kernel) 6.3 64-bit with lighttpd (in fast-cgi mode) 1.4.31 from EPEL rebuilt from SRPM with the 1.4.x backport patch for mod_uploadprogress applied and Roundcube's master branch.