calvinfroedge/PHP-Payments — pull request #14 by kuroi (2012-08-26 19:17:40+00:00)
Title: Correct test to identify methods with parameter 'identifier'

The current condition tests whether the length of the $m array has a single entry. However, this will never happen as setting $m = $method_map[...] immediately above ensures that it will always contain a minimum of 3 entries.

Thus processing will always drop into "else" clause, generating a PHP error for those methods (get_transaction_details and get_recurring_profile) that should have been dealt with by the "if" clause.

The proposed solution is not perfect. The 2nd condition is arguably redundant as there are no methods with a single parameter that is not 'identifier'. Conversely it won't deal with these two methods being called with superfluous parameters. However, it would at least avoid errors when they're called correctly, with no adverse effects for calls to other methods.