mozilla/browserid — pull request #2392 by lloyd (2012-08-24 18:27:07+00:00)
Title: Complete registration test fix

This should fix the most prominent failure in our unit tests which arises on many of our VMS, usually the slower ones.

The problem was that we were trying to test the registration landing page when verifying an email that was staged via 123done. Because the landing page redirects after ~5 seconds, we were doing a WebDriverWait with a non-automic test case. That test case would often (reproducibly > 50% of the time on osx/ffx saucelabs vm) fetch an element before page redirect, and try to extract the textual contents of that element after page redirect.

Now we wait for the redirect to occur which alleviates the timing issues.

In order to fix this I selectively merged some of @klrmn's fixes to the complete_registration bit of bidpom.

While some tests might be broken by this bidpom change, all we care about right now is 123done tests.