Dridi/querysort — pull request #1 by sengelha (2012-08-24 15:00:08+00:00)
Title: Handling URLs with trailing &

Dridi,

Morningstar is using your libvmod-querystring and querysort libraries on our internal Varnish servers. We have detected a crashing bug in the search_params() function in your querysort library for URLs which end with &, e.g. http://localhost?a=1&

I have submitted to you two changes in three commits:
1. Rewriting the search_params() function to eliminate the crashing bug and properly handle URLs with trailing &s
2. A check (http://check.sourceforge.net/)-based test suite for the querysort library to test many different URLs with the querysort function. This test suite requires Check 0.9.5 or newer (I use Check 0.9.8).

Thanks,
Steven Engelhardt