Yelp/firefly — pull request #27 by bigo (2012-08-24 19:17:42+00:00)
Title: fix creation of new blank SourceSelector when 'removing' the last one from the GraphEdit pane

the code to handle the events from the "remove" button in the GraphEdit pane is split into two parts - the SourceSelector object handles removing the source from the current graph and cleaning its own container up; the GraphEdit object handles adding a new SourceSelector if there are none left. But the GraphEdit part was totally borked and always has been.

This fixes that, renames rampant usage of 'that' (as a pointer to 'this') in the surrounding function, and patches one possible source of memory leaks, although probably not.