lutter/augeas — pull request #11 by jmccann (2012-08-23 14:43:24+00:00)
Title: fixes #278 multipath: allow devices to override defaults

Multipath lens only allows device subsections to set items in 'common_settings' in addition to a couple of 'unique' items (qstr /vendor|product|product_blacklist|hardware_handler).

A device should be able to 'override' or set items that are definable in the defaults section as well.

Attached is a diff of how things are now and what I am currently using to address some issues we ran into.

Addressed the following issues you brought up:

What about the SuSe? extensions async_timeout and max_polling_interval ? Your patch removes them
Not anymore :)

Can you add some tests to lenses/tests/test_multipath.aug to check the device sections accept settings ?
Added test for polling_interval in device section which previously wasn't allowed

Currently, the tests fail with your patch ...
I checked that after I made my changes the original test still worked, then added additional checks with the test still working