perone/rbstats — pull request #4 by SparkieGeek (2012-08-22 18:38:00+00:00)
Title: Show reviewers not targets

These changes are more substantial, and more controversial I suspect!

I was perplexed when I first ran rb_stats.py against my ReviewBoard server (with several hundred if not thousand of review requests) to only see one entry on the x-axis and one on the y-axis. My expectation was that the graph contained Submitters vs. Reviewers (i.e. people who had performed a review on a Review Request). Instead what I was actually seeing was Submitters vs. Target People; my ReviewBoard workflow uses Target Groups not specific people (apart from on the odd occasion - see the one entry!).

This set of changes makes rb_stats.py meet my expectations and plot the Submitters vs. Reviewers, but it does introduce a large performance penalty (as noted on a comment on commit 2f51f0c117b7102a1bc6af2f3c19cec9ae1841a2 ). The effect is exaggerated on Apache's ReviewBoard due to network latency - on my in-house ReviewBoard server, with the `.show()` commented out and no max-results override it takes 40s which I consider reasonable.

I'm open to suggestions as to how to improve this, or perhaps move it behind a command line flag.