viatropos/tower — pull request #202 by edubkendo (2012-08-21 06:05:53+00:00)
Title: Fixes issues with the new app generator not properly downloading vendor ...

This addresses the issue in which ember.js was not being properly during new app generation. What I discovered was that in almost all cases where the javascript file was not coming from a raw.github.com uri, the resulting file in the vendor folder would just contain the word "undefined".

In two or three of these cases, ember.js included, I was able to track down a version of the file at said type of uri. I attached them to specific commits, as well, so a sudden change wouldn't suddenly cause things to stop working.

In the case of sinon.js and prettify.js, this option wasn't readily available. So, in the meantime, I've stashed copies of those files in repo's of my own, and used a "raw.github.com" + commit number type uri to get them properly fetching into the vendor folder for now.

We will need to find a more robust solution, I think. Whether it's creating a repo of vendor files that tower needs and fetching all of them from them, or , what I would like to figure out is why it suddenly doesn't like parsing anything that doesn't come from these raw.github uri's. Perhaps it is something to do with some of github's recent changes? I'm not sure.

I looked back through older tower app projects I had generated and apparently some of these files have been coming through this way for a while now, but not forever. Maybe a month or two? Looks like around the time I made that tower demo-app, things worked fine. Since then some files stopped properly fetching and were going into the folder as "undefined" but apparently they weren't critical enough for anyone to notice before now, when ember changed? Although this may be/have been the source of some of the odd bugs I and others have experienced on the client side.

This, while a temporary fix, I think, will allow us to move forward with merging and let people work with tower without having to manually download a bunch of vendor files to replace the broken ones.