dblock/waffle — pull request #21 by hazendaz (2012-08-19 04:04:33+00:00)
Title: Findbugs / PMD / Junit Updates

The basic idea here was to upgrade junit 3 style tests to junit 4 annotation style. In addition findbugs and pmd were used to flush out any potential issues. Overall there were not really anything significant found through those tools but they did point out a number of issues. All is fixed below. This consists of 127 files. A couple of those simply were changing spacing to tabs such as in build files. The rest relate to below. I was going to separate out breaking changes but due to how imbedded throughout they were, I simply clearly listed them in the release notes. The breaking changes are minor and would only cause external users if they extend things to change a few names. No actual code changes are really necessary in these cases unless they looked for returned arrays and expect null rather than empty.

Updated code based on findbug and pmd results.
Updated junit 3 style to junit 4 style tests
Within waffle code, any methods returning boolean with getter now use
is*, see release notes for further details.
Fixed case on method in interface, see release notes.
All arrays used on getters that did return null now return empty arrays.