scottcsims/SeleniumFury — pull request #3 by flyinprogramer (2012-08-18 07:30:03+00:00)
Title: Works on 1.9 -- needs code review

** All tests re-written to use TestPage.html
** All tests were passing on 1.8 before re-write
** Changed to 1.9 with latest available gems [rspec 2.11] - stuff hit the fan
** [*] or "splats" now work differently in Ruby 1.9, in 1.8 our splats, or "catch-alls" would return the value directly if it were single, or return an array, if there were more than one. In 1.9, splats are now always an array, it seemed like none of the methods where they were used, even when drilled down, ever did any sort of array manipulation, which indicated to me, that we could simply evaluate the variable to "nil" if not present, hence the changes from *variable to variable = nil
** The RC verify_instance_variables and verify_class_variables needed an overhaul because Object.instance_variables and Object.public_methods now return arrays of symbols instead of strings. I believe I patched this correctly, our tests pass at least... basically it still iterates on the symbol, but I convert the symbol to a string, and the logic stays the same. However, for instance_variables test_page.method seemed to need the string version instead of the symbol, i believe this is a 1.9 thing because they made variables and methods look even more indistinguishable [they used to have an @ sign in front, now they don't].