purpleidea/puppet-gluster — pull request #4 by bitgangsta (2012-08-17 22:13:32+00:00)
Title: Fix puppet dependency and update to Gluster 3.3 CLI

Hi,

I am opening a second pull request to change which branch I submit this on. Sorry for two requests for the same issue. At any rate, this contains two fixes:

1. Puppet load order
2. CLI update for gluster 3.3

Some background:

When I attempted to use your puppet module, everything worked fine in my test environment. However, when I pushed to production, puppet was trying to load the volume resource before the brick, causing it to fail. I noticed you actually had a chained dependency in your code (but it was commented out). This pull request is to uncomment that line, which fixes my problem.

I looked at the blame and history log of your volume manifest to try and understand why you commented it, but could find no reason. It looks like it was commented out the minute it was added to git. Can you perhaps weigh in on why this line was commented out?

For the second issue this pull request addresses, gluster 3.3 seems to have a slightly different CLI syntax. I added a fix to gluster volume creation. It was using "gluster list" rather than "gluster info"

Thanks!
Daniel