MinecraftForge/MinecraftForge — pull request #121 by Draake (2012-08-15 22:47:05+00:00)
Title: Added additional sound events... (again, again)

You can't fold this information into the existing ones for so many reasons...

The current event focuses on changing the soundpoolentry. This requires that it be called BEFORE newSource which would make any SoundSystem.*(sourceName, ...) called in that event useless because the new source doesn't exist yet. There's also the problem of whether or not a mod will pass null for the event, which means that you'd have to increment latestSoundID regardless of whether or not it's going to be used.

Also, streaming sources do use the same source name every time, but since the current implementation calls newSource rather than just changing its values, it's required to have another new event in order to reset all of the needed values each time its called.

I'm the author of a mod that adds OAL-EFX such as lowpass filtering and reverberation to the SoundSystem, so I ask that you lend some credence to what I'm saying here. If you have any more concerns I ask that you address them without closing the request this time.

Original:
So apparently my last description of "Added additional sound events to allow manipulation of a sound source at its creation" wasn't concise enough.

The current sound events pass everything except a unique string which paulscode.sound.SoundSystem dubs the "source name". This string is needed in order to manipulate any of the sound source attributes (ie, looping, temporary, etc) directly through the SoundSystem instance.

These changes add additional sound events that pass on this currently unavailable (and useful) information.