bevry/query-engine — pull request #17 by andrewjshults (2012-08-14 23:02:07+00:00)
Title: $has queries break if test value coerces to/is false

It looks like util.toArray converts false to [] rather than [false], so the Hash.hasIn test fails because the CS version gets converted to *if(value)* (line 127 of query-engine.coffee, line 91 of query-engine.js). It seems like this should test to see if the value isn't undefined rather than coercible to true, since false, 0, and '' may be valid tests (false is in my case).

I added a test specifically for this and it looks like all the other tests are still passing, but since I'm just getting started with this project wasn't sure if there are any other areas I should poke around to make sure I didn't break anything.

Cheers!
Andrew