mbruker/Cockatrice — pull request #77 by thekid42 (2012-08-13 03:50:52+00:00)
Title: fixed card prices

While using the price check feature, I noticed that certain cards are being given a higher dollar value than I would expect them to have. In particular, I found that the value of a Forest was determined to be $3.20, rather than ~$0.10. Upon inspecting the source code as well as the JSON file pulled from blacklotusproject.com (http://blacklotusproject.com/json/?cards=Forest for this example), it looks like that value is the value of a Forest from the Zendikar set, the last match for "Forest" in the JSON file.

Given that Cockatrice does not require players to purchase cards, that cards are purely functional, and that aesthetics are irrelevant to functional value, it seems like the price of a card should be based on the edition of that card with the lowest average value.

I added a check in priceupdater.cpp to ensure that the card value returned is the lowest average price, rather than the value of that card in the last alphabetical set it was released in.

Thanks!