nsisodiya/Demo-Scalable-App — pull request #1 by eric-brechemier (2012-08-11 08:52:05+00:00)
Title: Code review

Hi, here is a pull request with my comments.
No need to merge, you can close the pull request after reading.

I found the presentation PDF quite good, the principles of the Scalable JavaScript Architecture are presented in a clear way, with well chosen examples. I indicated suggestions for improvements and fixes in an empty commit.

On the other hand, I find that this example is not representative of the Scalable JavaScript Architecture library, because it makes use of too many idioms that you developed on top. It is totally OK to extend the library and I'm glad that you could adapt it to match your needs, but as a consequence, that does not make it a very suitable example of the library in my opinion.

What do you think?