marcelog/PAMI — pull request #34 by jacobkiers (2012-08-10 11:23:19+00:00)
Title: Removed warnings on socket errors and ClientImpl::getLine()

Hi Marcelo,

Would you please pull these changes?

Removed the warnings, because:

1. You already *will* know something went wrong (because of the Exception)
2. If you catch the exception and do something with it, the warning just becomes unnecessary noise in the error log or on STDOUT.
3. In other places, they were already ignored.

Also, I've removed the ClientImpl::getLine() function, because it is used only once. For the reasoning, see the following quote from the commit message:

> Even though a possible argument for keeping it may be that it abstracts
away getting a single line, I don't think that is a really strong
argument.

> Because this function is only used once, and in a function that directly
uses socket functions itself already, this makes the code more complex
than needed.

Of course, I can revert that commit, and send it as a different pull request, if needed.

Thanks!