chrisa/perl-Net-SAML2 — pull request #3 by marschap (2012-08-05 18:32:21+00:00)
Title: Updates for Net::SAML2 0.17

Hi,

please consider pulling the following changes into Net::SAML2's upstream repo:

* Sig.pm: improve compatibility with simplesamlphp
This is a minimal patch against Sig.pm to make Net::SAML2 work with simplesamlphp.
It is taken from https://rt.cpan.org/Public/Bug/Display.html?id=76260, and has -
as you suggested - the namespace change left out.
I can confirm that this version works as the original patch from #76260 did.

* documentation updates
A bunch of documentation updates:
- document required parameters
- consistently format methods & parameters: one space after ( , one before )
- document argument lists using pod's =item parameters to follow standard conversions
instead of having then shown as code blocks
- ... (some more minor things)

* IdP.pm: simplify $idp->format() a bit
Make the 'return' at the end unconditional instead of having it wrapped in an 'else' block.

* add additional attribute 'key' to Net::SAML2::SP
Allow to have certificate & key files separate by using two different parameters when
creating the SP object. The new parameter 'key' points to the filename of the private
key of the file given in 'cert'.
This helps with distributions like e.g. Debian that separate certificate & private key files.

It would be great if they made it into the next version of Net::SAML2