ato/clojars-web — pull request #67 by rkneufeld (2012-08-05 03:27:31+00:00)
Title: Better error pages (Fixes #60)

Hey, I'm back with a proposal for adding error pages that I would like your opinion on.

I went with the originally proposed middleware setup (where the final piece of middleware catchs `Throwable`s, logs them, and then shows a simple error page). This middleware lives in [web/error_page.clj](https://github.com/rkneufeld/clojars-web/blob/b44b15bef6fb2940cf0294059b128b9185564534/src/clojars/web/error_page.clj).

I also wrote two integration tests for this middleware. One checking that an error page is displayed, and another checking that a message is logged. Unfortunately I was unable to eliminate the noise generated by throwing two exceptions. Try as I might, I wasn't able to capture them from *out* or *err* where I would expect they were being emitted too. **Perhaps you might see a solution or what I might be doing wrong?**

I did also notice four failing tests, however, those tests also appear to fail on master. This may be an environment problem on my end though. Before you might accept this request, please double check on tests.

Also Missing:

* A stack trace or log identifier (I want to add these to this request tomorrow).

*Any feedback or opinions you had would be appreciated.*