symfony/symfony — pull request #5181 by Tobion (2012-08-05 03:52:52+00:00)
Title: [Routing] fixed 4 bugs in the UrlGenerator

This was pretty hard to figure out. I could fix 4 bugs and refactor the code to safe 2 variables and several assignments. Sorry for doing this in one commit, but they were highly interdependent.
I had to adjust one test that was asserting something wrong (see comments).
See the added tests for what was fixed. The most obvious bug was that a query param was ignored if it had by accident the same name as a default param (but wasn't used in the path).