opscode/knife-ec2 — pull request #63 by jontg (2012-07-31 20:59:37+00:00)
Title: Removing defaults that clash with the config file

I found that knife.rb values weren't being respected; in particular, if knife.rb contains

> knife[:region] = 'us-west-1'

then the results of

> knife ec2 server list

differs from that of

> knife ec2 server list --region us-west-1

and after some digging, it looks like Mixlib/CLI's :default value is beating out Chef::Config[:knife][:region] (vis a vis the locate_config_value(...) function). Some of these defaults aren't particularly valuable, and so I have made a few changes. These are:
* Removing default values for
** region
** flavor
** availability_zone
** subnet_id
* Changed subnet_id and security_group_ids to use locate_config_value(...)