dblock/waffle — pull request #8 by hazendaz (2012-07-31 01:48:22+00:00)
Title: 1.5

Lots of updates...3rd party stuff, added servlet3 set of code...

I think the 3rd party directory examples should be dropped because it makes for such large file changed items. Items I'm referring to include tomcat webapps directory. Just the base stuff is needed for this to work (ie licenses / jars). What do you think? I replaced them again this time around but this amounted to excessive amount of files for tomcat 5, tomcat 7, and the spring stuff.

I'm unable at the moment to run the junit reports so I'm sure there are additional items still to change. See eclipse bug below for issue. All the other tests with exception of the couple that never worked on my machine do in fact work so I believe things are mostly correct.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=384757

I did an overall format with default eclipse settings so it didn't change too much but made it easier for me to compare between versions. I also added some of the license info to make units match such as in tomcat 5 case it was the older style.

I still do not believe git hub for windows has resolved changing character settings. Based on the last tomcat 7 format changes I submitted, it appeared to have same issue. Eclipse is formatted using windows cp1252. However, commit in git hub for windows appears to convert this to unix format thus losing carriage line feeds. I haven't figure out how to report the issue yet but will do so at some point here.

Anyway, just wanted to get all this over to until I can resolve some of my issues noted here.