rsim/oracle-enhanced — pull request #202 by powerpak (2012-07-26 16:39:54+00:00)
Title: Fix bug in setting conn.non_blocking via config[:allow_concurrency]

On my OCI8 (2.1.2) creating a new connection by default sets
non_blocking to true. However, the line changed here would not
set non_blocking to false even if async was false, so there was
no way of overriding this gracefully from the passed in config.

irb(main):004:0> c = OCI8.new 'username', 'password', 'DATABASE'
=> #
irb(main):005:0> c.non_blocking?
=> true

The new behavior is to leave conn.non_blocking as the default if
`config[:allow_concurrency]` is nil, and forcefully set it otherwise.
I think this aligns with what users would expect when adding that line
to their database.yml.