donkirkby/live-py-plugin — pull request #2 by fabioz (2012-07-25 18:46:48+00:00)
Title: Some changes to integrate a bit better with PyDev

Hi Don,

I was curious and did some evaluation to see how it worked :)

I did some changes especially when launching to have it get the proper pythonpath for the project. Also, when doing the exec, the \r\n needed to be changed for '\n' (windows) -- sending pull request for those.

All in all, I think the implementation is nice... what bothered me most is that it's continually updating the code at each minor change. I think it could be changed to do that on a save operation (you can use pyEdit.addPyeditListener() to add a listener for the save operation).

Also, the actual execute should happen in a background thread. You can use the Eclipse Jobs API to create a job where you call job.schedule() whenever a change happens -- or on save as I outlined above -- or maybe make that a preference :)

I still didn't see much in the Python side, but one major thing that bothered me is that it didn't support Python 3 -- I initially had it and it took me some time to discover that it worked only on Python 2.x -- that's why I did the DEBUG flag :P

Also, it'd be nice if you put a file with the license for the code in the repository :)