openshift/rhc — pull request #104 by J5 (2012-07-23 14:57:00+00:00)
Title: * DO NOT MERGE * J5's domain refactor - request for comments

Some notes:

* all domain actions have been reimplemented with the exception of rhc domain status which just runs rhc-chk
* I have not deprecated the rhc-domain and rhc-ctr-domain binaries yet
* rhc domain show has similar output to the old show but I still need to implement git_url and app_url. It looks like we could make this output a bit more readable so comments here are welcome.
* rhc domain create/alter do not create or upload ssh keys anymore. This is a holdover from the old API and I think it should just get removed anyway. If we care about this we should have rhc setup run if it detects you don't have ssh keys for any command that is run.
* I have not done anything with --timeout. This and retries should be integrated at the REST module layer and I haven't decided the best way to go about this just yet.
* Help formatter is now in commander for any invalid command. This is because commander now handles any command that is not recognized in the rhc case statement.
* there are a couple of place that you will notice I :nocov:'ed around raised exceptions. These are asserts that should never be reached. If they are it means the rest modules are not detecting server errors and throwing them correctly.
* For delete do we want to add a prompt (that doesn't show up if --noprompt or perhaps --force is enabled?) e.g. Are your sure you want to do this? - does destroying a domain delete all apps or is this independent?
* rhc domain still defaults to rhc domain show - do we want to preserve this or do something else like display help to be more consistent across commands?
* rhc domain create is now the preferred way to pass the namespace. You can still specify -n or --namespace but specifying both the arg and the switch will error out and show you the usage help
* please run through all the help for all the commands and comment on verbage/format/issues
- rhc domain help
- rhc domain create help
- rhc domain alter help
- rhc domain destroy help
- rhc domain status help