xen-org/xen-api — pull request #785 by johnelse (2012-07-23 17:19:17+00:00)
Title: Remove redundant checks from VM.set_is_a_template.

These checks are not needed as these cases are already handled by the
allowed_operations code.

Tested by checking that converting a VM into a template is blocked (and not an allowed_operation) in the following cases:

* A VM is a member of a VMPP.
* A VM is a member of an appliance.
* A VM is a member of both a VMPP and an appliance.

...and checking that a VM which is a member of neither a VMPP nor an appliance can be converted to a template.