aharjula/maximapool — pull request #5 by timhunt (2012-07-20 18:53:20+00:00)
Title: Refactor

OK, so I think this is finished. It seems to work for me, and I find this easier to understand. Of course, I would find it easier to understand, I organised it like this.

The significant changes are:

1. Split MaximaPool into separate MaximaServlet (which deals with the HTTP bit) and MaximaPool (which manages the pool of processes).

2. Move all classes into separate files.

3. Move the generic utility classes into a separate fi.aalto.utils package, so that fi.aalto.maximapool just contains specific code.

4. Move storage of configuration into separate classes where it can be documented, and so the configuration parsing code is out of the way. As part of this, you can now configure the servlet to read extra configuration from another file, so you can change the configuration without recompiling.

5. Go through all the classes and reduce the visibility of all the fields and methods as much as possible.

6. Add JavaDoc comments everywhere.