JakeWharton/mkvdts2ac3 — pull request #80 by 1951FDG (2012-07-18 13:11:11+00:00)
Title: Fixed 4 Minor Bugs & Prettified Output

#### [Use the default value "eng" if the "language" element itself is not present in the file.](https://github.com/1951FDG/mkvdts2ac3/commit/3bd48330eaa141c1081aacf3569693a85879cd4f)

Starting with version 4.0.0 mkvmerge does not write elements to output files whose value equals their default value. mkvinfo only lists elements that are actually present in the file. If a track does not contain a "language" element then the default value "eng" must be used by mkvdts2ac3.

"eng" is the default value for the "language" element.

**Before fix:**
DTSLANG=
(output_file) - Language: und

**After fix:**
DTSLANG=eng
(output_file) - Language: eng

#### [Added missing line "color OFF" at the end of info()](https://github.com/1951FDG/mkvdts2ac3/commit/2631152848becbce0038cba90996a383b4aeb423)

**Before fix:**
blue colored output until color YELLOW called

**After fix:**
blue colored output terminated upon end of info()

#### [Standard Practice](https://github.com/1951FDG/mkvdts2ac3/commit/6954d57dbe5960657dd8fa05cbdc4730d145a3e9)

The value "VALID" for debugging was not defined beforehand like other debugging values.

**Before fix:**
if (--test), RESULT:VALID=

**After fix:**
if (--test), RESULT:VALID=VALID

#### ["ERROR: " was mentioned twice](https://github.com/1951FDG/mkvdts2ac3/commit/348e5ee975101851dba5ac42bb7002151d809e7d)

"ERROR: " already present in error(), duplicate text removed to prettify output

#### ["RESULT:DTSLANG=$DTSLANG" -> "RESULT:DTSNAME=$DTSNAME"](https://github.com/1951FDG/mkvdts2ac3/commit/aa75906c6d41b26ebbaf23b0c028c459e00c92d7)

The value "DTSLANG" for debugging was shown twice and the value "DTSNAME" for debugging was not shown.

**Before fix:**
if (--test), RESULT:DTSLANG=$DTSLANG, RESULT:DTSLANG=$DTSLANG

**After fix:**
if (--test), RESULT:DTSLANG=$DTSLANG, RESULT:DTSNAME=$DTSNAME

#### [Use info() for several alerts](https://github.com/1951FDG/mkvdts2ac3/commit/e4bfc25e91f7482787caf39174c8b06e6d5a8a28)

Used info instead of echo for "Use -f or --force argument to bypass this check." && "Force mode is on. Continuing..."

Also used info for "Moving new file over old file. DO NOT KILL THIS PROCESS OR YOU WILL EXPERIENCE DATA LOSS!" && "Moving new file over old file. DO NOT KILL THIS PROCESS OR YOU WILL EXPERIENCE DATA LOSS!"

color YELLOW is not very readable and color BLUE stands out more making it highly distracting to the eye thus demanding attention.

#### [Standardization (doprint -> doprint "")](https://github.com/1951FDG/mkvdts2ac3/commit/d2410c0f6cdc3bb0b3b27b63d034789733846961)

Standardization, nothing more to mention...

#### [Prettify output](https://github.com/1951FDG/mkvdts2ac3/commit/36eba855b31fa390bee7762b2c2e49840351c97c)

Removed extra spaces, added echo "", added/removed doprint "" where needed, and added a newline to RESULT:INFO=\n$INFO to prettify output (more easily readable output).