xbmc/xbmc — pull request #1178 by midripps (2012-07-18 08:32:28+00:00)
Title: Proposed fix for thumbs not auto-generating for some iPhone MOVs.

This is a fix for the problem I encountered and documented here:

http://forum.xbmc.org/showthread.php?tid=135725

It is a simple and conservative fix that simply doubles the hard coded limit for how many packets the thumb extraction will scan looking for a complete frame. I found this was enough to extract a thumb from all the iPhone MOVs I have. I also extended the logging to log how many packets it took to extract a thumb (or to fail to).

Questions remaining for me are:
1. Is this limit needed at all?
2. I can see that having a limit avoids long running threads while browsing, so is doubling the limit enough, or is there a way I could establish what a 'good' limit should be (I am not all familiar with these file formats)?