dingproject/alma — pull request #10 by mikl (2012-07-17 19:01:06+00:00)
Title: Removed auth check from add payment callback.

The addPayment Alma method does not require authentication, so this
check is uneccessary, and might cause problems with expiring sessions,
or using a different session backend than the database.

We were having issues with failed payments due to this check on bibliotek.kk.dk, for reasons we are not quite sure of yet.

However, the system should err on the side of caution here, since any failure in this part of the process results in defrauding the paying customer. Basically, we take his money, but does not mark his bill as paid.

This change also obsoletes all the session juggling code in https://github.com/dingproject/ding/blob/master/ding_dibs/ding_dibs.module#L60, but we should probably wait before removing that, since it currently causes no harm.