dominno/django-moderation — pull request #66 by mlavin (2012-07-13 16:39:03+00:00)
Title: Django 1.4 Compatibility

This is an alternate to @CBWhiz's pull request to add Django 1.4 compatibility. This does not add additional features and only updates the admin filtering and test cases to pass on Django 1.4. Beyond the broken imports due to the new filtering API in Django 1.4 the test cases were failing due to the removal of the old `user.messages_set` API in favor for `django.contrib.messages` added in Django 1.2. A couple notes on these changes:

- Django 1.1 support has been removed. This is partly due to the lack of `django.contrib.messages` but also the removal of the `DATABASE_*` settings and the changes to some of the context processors, middleware and template loaders makes it difficult to run the tests on all of these versions. While it might be possible it just does not seem worth the effort to me. Django 1.1 is almost 3 years old and has not received security updates in over a year.

- PEP8 tests require `pep8==0.6.1` to pass. These tests pass on CI which was last run in Feb 2012 when `0.6.1` was the current release. On the current `pep8==1.3.3` release these do not pass. While I like PEP8 as much as the next person, enforcing it in a test case violates PEP8's section [A Foolish Consistency is the Hobgoblin of Little Minds][1] in my opinion. If there places where the code could be cleaner I'm happy to make those changes.

Thanks to @CBWhiz for a solid reference for making these changes. Let me know what improvements could be made to have this merged.

[1]: http://www.python.org/dev/peps/pep-0008/#a-foolish-consistency-is-the-hobgoblin-of-little-minds