navtable/navtable — pull request #54 by amaneiro (2012-07-11 09:55:00+00:00)
Title: Review pullrequest 51

This pull-request is my way of reviewing #51 - I had some doubts on what the pull did, so I prefered reorder the contents to understand better the problem. Jorge, as I learned what your proposal was, I rewrote some parts of it:

- **keep deleteRecord() method in AbstractNavTable**. This is not needed for this pull. I know maybe is better to keep simetry and implement it in NavTable (saveRecord already is down to NT), but as it is used in other places (NavTableForms) and will require repeat the same code in several places, I prefer to look for a more general solution.

- **drop deprecated methods**: as we change the API, I took the oportunity for dropping the methods we don't use.

- **return values for startEditing and stopEditing**: as they need mapcontrol, I think is convenient return a value to let the developer know if the process was OK or not. Probably, in mid-term, a better approach would be to thrown an NavTable exception.

Other known projects (NavTableForms and extTOCExtra) would be affected by the changes in ToggleEditing, but they are trivial and I have already patches for them. Please, check EIELForms.