Macadamian/titanium_mobile — pull request #95 by jpl-mac (2012-07-06 22:07:40+00:00)
Title: TIMOB-9897 Blackberry: address comments from Martin's review

Reviewers: Harut, Alex

This patch is to address comments from Martin. JIRA issues have been created to track omments that require more time to resolve.

Changelog:
- created enum for NATIVE_ERROR for consistency with the rest of the file
- added comment in NativeObjectFactory::createNativeObject stating where the created instances live and get deleted
- added deleteInstance function to NativeStringInterface so we can delete it at shutdown time
- added comment to empty methods onCreateStaticMembers and onSetProperty in TiObject class
- added comment for overriding onSetProperty in .h
- moved using namespace lines from TiV8EventContainer.h to cpp
- removed unneeded forward declaration of TiInternalEventListener
- moved TiInternalEventListener comment just before class declaration
- release the TiRootObject at the end of script execution so it gets deleted properly
- Added asset path to the js scripts for tibbtest

Tests:
- Built and ran app.js (provided in JIRA ticket)
=> Made sure that the event handling still works
=> Used String.format to make sure the modification to delete the instance didn't break it
=> Verified that the deleteInstance code gets invoked when during the app shutdown, using debug logs