rubensayshi/d3-ehp-calculator — pull request #53 by smerchek (2012-07-05 17:19:04+00:00)
Title: Added ability to equip the 'New Item' in the Item Compare screen. fixes #34

Couple things to note about the design here.

I put the button on the New Item next to reset because it feels like you are really performing the action on the New Item. This simplifies the button, because it can merely say 'Equip' rather than 'Equip New Item' or something like that.

I also decided that it makes sense to disable the button if 'New Item' has no changes (it is in the default state). This will help accidentally clicking Equip twice and overwriting your equipped item. I think that this will be good enough to prevent people from making mistakes, but I'm open to also having a dialog to confirm. However, dialogs can often be annoying, so I'd like it to not need one. That said, we might want to move it away from 'Reset' a little more.

Let me know what you think of these changes.