basho/riak-chef-cookbook — pull request #34 by davidx (2012-07-03 21:18:57+00:00)
Title: Fix all but one Foodcritic suggestions

This pull request contains style fixes to comply with chef community/opscode best practices.

FIXED:

FC001: Use strings in preference to symbols to access node attributes
FC007: Ensure recipe dependencies are reflected in cookbook metadata
FC013: Use file_cache_path rather than hard-coding tmp paths
FC016: LWRP does not declare a default action
FC019: Access node attributes in a consistent manner
FC023: Prefer conditional attributes
FC024: Consider adding platform equivalents

TODO:

FC003: Check whether you are running with chef server before using server-specific features

(complete foodcritic epic-fail output: https://gist.github.com/c089db2e949e038e38ee)