travis-ci/travis-core — pull request #76 by drogus (2012-07-04 05:52:35+00:00)
Title: Secure "env" configuration - continuation

I rebased the work that @laserlemon pushed in his pull request (#45) and ensured that `ENV` variables are not decrypted for pull requests.

I haven't added `TRAVIS_SECURE_ENV_VARS` and `TRAVIS_PULL_REQUEST` env vars yet, as I'm not sure what is the best place to do it. For now I added `pull_request` key to the API and I planned to export those variables in the worker, but I'm not familiar with travis' architecure yet, so I would like to get some feedback for this.

The other thing is that I don't like the fact that we need all or nothing approach. If you want to have secure `ENV` vars, you need to encrypt all of them and because of that there is no way to set both types of vars. Can I also address it in this pull request? And if yes, have you guys thought about approach to this problem or is this something that hasn't been discussed before?