carlasouza/puppet-virt — pull request #6 by riseuplabs (2012-07-01 18:15:19+00:00)
Title: merge from immerda

Hi,

I was looking around for the best puppet virtual module, and I found yours, but I also found that the immerda group had made a number of recent improvements that were not contained within your repository (git://git.puppet.immerda.ch/module-virt.git).

Their changes were on top of your unstable branch, which has not seen commits from you since 2010. You have been making other commits in the master branch that were useful. So what this meant was that you had new things in master, and immerda had new things in unstable. Time for a merge!

I've done that merge, and resolved the conflicts and I present to you this pull request to consider. The biggest difference here is the class refactoring that immerda did which brings your module in-line with best practices for module auto-loading. It places different classes into files, rather them being all in init.pp and params.pp. This is a really good improvement, but hard to wrap your head around when it comes to merging.

Anyways, have a look, it would be good to get these sync'd up as I think both of you have been doing good work. Let me know if you have any questions.