basho/riak_core — pull request #203 by jtuple (2012-06-28 21:02:56+00:00)
Title: Fix handoff_ip bug in mixed version clusters

This pull-request fixes the handoff ip bug identified by @rzezeski when investigating failures in the rolling upgrade basho_expect test. The change replaces the use of a `gen_server:call` with an `rpc:call` to prevent older nodes from crashes because they do not expect the `handoff_ip` message.

This pull-request also addresses another issue with cluster transitions stalling due to either missing ring change events, or due to a race between cluster capabilities negotiation and claimant transitions. This bug was hit when working on an automated test to trigger the original handoff ip bug that was being fixed.

I've also added a new `verify_basic_upgrade` to `riak_test` that verifies correct behavior after these changes (failing without). We will need to re-build packages and verify against the basho_expect rolling upgrade test to see if there are any other issues.