jclouds/jclouds — pull request #690 by aledsage (2012-06-26 09:15:14+00:00)
Title: Issue 989: handles transient node-not-found in nodeRunning

Sometimes on aws-ec2, the client returns null (i.e. node not found).
This fix will cause us retry with the correct node-id, rather than
"forgetting" the original nodeId and retrying with null each time.

---
I'm not particularly happy with the implementation for this. However, because state is only
passed in the argument to NodeRunningRunning (and never in any fields) then it's hard to do
much better (particularly become some calling code relies on the return value of null). Suggestions welcome!

I haven't changed serverDeleted or serverTerminated as they use null to conclude success.
However, the fact aws-ec2 seems to sometimes incorrectly returns null (temporarily?) means
that we might erroneously conclude success. I'm not addressing that in this pull request because
it's speculative, and it's not connected to issue #989.