ORCID/ORCID-Example-Client-Application — pull request #4 by arthurpsmith (2012-06-25 18:14:11+00:00)
Title: Working search

So - search is working here most reliably as a tier-1 service. If you're already authenticated to tier-2 via the main /info page then tier-2 search works as well. The changes here were to:

* in the original OrcidServiceImpl, move the standard OAuth2 authentication pieces from the getDocument() method to an internal class so it could be more easily shared by different methods
* fix up the search method in that service
* implement a separate OrcidPublicServiceImpl that uses the tier-1 URL's without any OAuth2 requirement
* update the OrcidController to use both tier-1 and tier-2 methods (the tier-1 methods used for ORCID's that are not the one authenticated with OAuth2, and for searching though it works with both).
* updated orcid.properties so both search and fetch url's are provided for both tiers
* updated the jsp files to link to one another via the controller actions properly...

It may be the tier-1 API is sufficiently different (update methods only for tier-2 for instance) that it should support a completely separate interface rather than the shared OrcidService interface I've put in right now... it didn't seem necessary yet but perhaps next iteration. Anyway, I think this is an improvement over the last version, so I hope you can just pull it in, thanks!