webbit/webbit — pull request #93 by s1monw (2012-06-25 09:54:15+00:00)
Title: Wait for executor services to shut down and "name" internally controlled threads.

I looked at the ignored test again, this is kind of a "its not a bug its a feature" situation of executor service that doesn't necessarily shut down immediately. I added an ExecutorService#awaitTermination call to the #stop future that should provide best effort. If that doesn't hold during tests the assert should be tripped but won't break production services.

the second commit adds a NamedThreadFactory that I wrote years ago from apache lucene to give threads created in a ExecutorService a name. This would help me massively to debug things if something goes wrong since these names are visible in the thread dumps.