github/gollum — pull request #393 by dazoakley (2012-06-21 16:04:37+00:00)
Title: Add Directory Support

Hi,

This is a pull req. for https://github.com/github/gollum/issues/368

These are the changes, (back-ported and tidied up) from the nature/deagol fork i've been working on. Basically this makes the entire gollum web app work nicely over a directory structure (rather than a flat, single directory).

The only request this doesn't resolve (on #368) is the "File creation should be directory aware." thing. I wanted to ask an implementation/UI question about this one...

For our purposes, we've altered the /create logic to allow users to type in a full path name, (i.e. Gondor/Faramir to create a Faramir page within the Gondor directory). But this seems a bit of a hack (as you can't create pages named with the / character), and it might be better to add in a directory selector to the 'New Page' popup.

Another thought I had re this use, maybe only have the new page button on the /pages view, then it could automatically create a new page within the directory the user is currently looking at? This would be a lot easier to implement...

Maybe this could be done as a separate pull if you're all happy with these current changes?

Anyway, let me know if this is ok and what you think.

Thanks,

Daz