atlasapi/atlas — pull request #148 by sbtourist (2012-06-21 09:31:04+00:00)
Title: Recent changes logger refactoring

Hi,

I've done a quick refactoring to the recent changes logger implementation, and I'm doing this as a pull request so that we can briefly discuss about it.

I'd like you to focus on the following changes:

- I renamed worker properties (i.e. "messaging*.recent") and bean names: those things should express verbs (i.e. I used "logger" but feel free to change it), not attributes.

- I enforced separation of concerns by moving the recent changes controller implementation outside of the worker: this also enforces the principle of least astonishment (where astonishment is what happens when you open the worker class and you see it is a controller too, or when you look for the controller and you don't find it because buried inside another class).

- I moved the recent changes store where it belongs: that is, together with other persistence stuff (there's a TODO note there that I'd like to review in the future).

That's pretty all.
Feedback is *mandatory*, ranging from inline comments into the diff to a simple yes/no boolean ;)