Redth/PushSharp — pull request #2 by eloe (2012-06-21 23:12:28+00:00)
Title: Have some possible enhancements

Hello,

Our company has forked this project after looking at your previous APNS-Sharp project. We are building a fairly large notification platform for mobile devices. Great work so far!

Anyways I have modified the code some to allow the ability to pass a Tag object into any notification. We need the ability to update our database after we know a notification has been successful or failed. To do this I now set the Tag object with our own internal notification object so that I can update the server once the event callback has been fired.

I also created a PlatformType.None. I didn't want to create our own enums for error checking so went ahead and added that to your enum to reduce the redundancy.

As we build out our notification platform I'm guessing we will have more pull requests to you. One question we did have was in regards to the teardown process of the PushService. You pass false in for waitForQueueToFinish instead of true, was their an intended reason behind this?

Ideally we where thinking of making this configurable because in our testing we have noticed when we reach this code we still have 1,000+ notifications waiting to be sent to Apple and they just get dropped and never sent. If you would like to contact me on an easier form you can gchat me at eric@buddytv.com.

Thanks for the project and hopefully I can contribute!

- Eric