LearnBoost/knox — pull request #71 by shuzhang (2012-06-20 21:11:13+00:00)
Title: Please review change

Hi, here're the details of my change:

Ensure propagation of errors in http module.
When an error occurs in the core http module, an error event is emitted by a request object. For knox client's putFile, putStream, readFile, etc. the caller does not get a reference to the request object and does not get a chance to catch errors occuring in http module except through a global error handler. This change ensures errors occuring in the underlying http module are propagated through the callback function.

The easiest way to repro an error occuring in the http module is to try and send a request without an active internet connection. I believe the default behavior is a crash.

Thanks,
Shu