bernat/best_in_place — pull request #160 by mstahl (2012-06-20 18:43:50+00:00)
Title: Use dom instead of string concatenation like a boss

These weren't working on an app that @Bantik and I are working on, so I changed the methods that build inline forms so that they use the jQuery DOM methods instead of concatenating strings together. The concatenation was breaking because we have a select box that has heights in feet/inches in it, which were escaped in our code but when concatenated and dumped to the browser resulted in invalid HTML attributes being created. Using the DOM should be a lot more robust and easier to maintain.

Also added a "height" attribute to the test app's user model with a select box similar to the use case in our app, with tests to accompany it.