sergiogonzalez/liferay-portal — pull request #284 by matethurzo (2012-06-19 14:19:04+00:00)
Title: [TECH SUPPORT] LPS-28021

Hi Sergio, This is a small but tricky fix for the asset publisher RSS feature. The original problem was that the RSS is not supported for the manual selection mode, however this scenario was not handled properly in the portal. This change will provide a fix for this problem. I've refactored Kalman's original fix for the following reasons. Zsigmond and Julio had a mail thread about this problem and Julio advised to fix this in the ConfigurationActionImpl, and I agree with him. We have previously faced some problems for remote staging because of the inconsistent state of the asset publisher portlet preference. Kalman fix left the preference in an incosistent state, because if you saved the portlet first with dynamic display style with RSS enabled, then you have changed to manual display style the enableRSS preference was still true. I think it would be a better fix if we wouldn't allow this kind of inconcistency at all. Kalman placed some more business logic into the ini.jsp of the portlet, but this more belongs to the backend, the front-end has not much to do with these stuff. Based on these reasons I've decided to move the fix to the ConfigurationActionImpl. Please let me know if you have any questions or concerns. Thanks, Mate