rubensayshi/d3-ehp-calculator — pull request #35 by rubensayshi (2012-06-14 08:21:32+00:00)
Title: Sharedbuffs

To be able to share buffs between classes (warcry, mantras) I moved all the options / base_options etc into the static properties instead of the normal properties of the classes.

And I had to move the logic that checks which boxes you have on and modifies the armor/resist/life/etc from the character classes to the base class.

Tbh, the static properties change is ok, but I'm in doubt about moving all the logic into Character ...
It's a bit dirty, having the logic seperated by class was a lot nicer, but it ain't that much logic and it's fairly simple and won't change much so that might make it ok ...

Anyone got an opinion about it :D?