jgorset/facepy — pull request #44 by jjmaestro (2012-06-13 17:41:50+00:00)
Title: Twoapart cleanup

Hi there!

Here's a bunch of simple and nice changes. We needed quite a few of them and

The main features added / changed are:

- `GraphAPI` receives a URL so that the FB API can be mocked in testing / development (e.g. using [TwoApart/mockfacebook](/TwoApart/mockfacebook))

- Refactoring and adding a `get_fb_data()` to `SignedRequest`: it simply returns the data dict of the signed request. We don't want to handle the full `SignedRequest` object in our app, we only need to check a couple of little things from the data dict.

- Adding FQL support (not really important since it's just a one-liner wrapper over GET but still, we find it nice and handy :)

- Removing the non-existent max version on request: it makes no sense to say "such future version of requests will be incompatible" if it's not. Plus it can cause dependency conflicts in the near future (it already happened to us with an old version of facepy that insisted in requests < 0.9 or something like that...)

Finally, we are open to discuss any of these changes with you. Although we would love to see all of these getting into master, please feel free to cherry pick whatever you think is suitable.

Thanks so much in advanced,

Cheers,

Javier