modxcms/revolution — pull request #324 by exside (2012-06-11 14:34:55+00:00)
Title: Fix for custom help URL not working properly

If the base_help_url is set to something other than the standard RTFM URL, the help button doesn't work properly because something (couldn't find out where/what) is adding a postfix (like "/Resources") to the URL, which of course does only work on the RTFM Site.

I think that it is the $action['help_url'], but I'm not deep enough into the code to understand what it exactly does^^.

So what I did here is to just see if the base_help_url system setting was changed, and if it was changed, just don't do the $action['help_url'] postfix thing to make the custom URL work properly. I commented out the original line, if pulled into the master branch, this should be removed.

The whole issue was also filed here http://tracker.modx.com/issues/7786 but closed prematurely (in my opinion)

Dependency: MODx.loadHelpPane Method (http://rtfm.modx.com/display/revolution20/MODExt+MODx+Object#MODExtMODxObject-MODx.loadHelpPane) which gets the $url param from this file.

Related Issue: If I set a context setting "base_help_url", it isn't respected, only the system setting is taken.