theforeman/puppet-foreman — pull request #4 by iNecas (2012-06-11 15:00:26+00:00)
Title: parametrize params so that they can be overwritten

Taking the approach from puppet-puppet that allows reuse the manifests by
overriding the params like:

class customized_foreman {
class { '::foreman': passenger => false }
}

I've followed the changes made in puppet-puppet. However I had a problem with this files:

./manifests/config/enc.pp
./manifests/puppetmaster.pp

They include `foreman::params` directly. Therefore they can't use the parametrized version, therefore I'm leaving there `foreman::params::` prefix. They also use this templates, so I've left the params there untouched as well:

./templates/external_node.rb.erb
./templates/foreman-report.rb.erb

It seems to me it might be worth to separate this files into separate module since they don't share almost nothing (other manifests or templates) with the foreman module. Or am I missing something?