gbadiali/twitter-cldr-rb — pull request #1 by KL-7 (2012-06-11 19:10:06+00:00)
Title: Switching from KeyPath to plain Array

Hi, nice to see you working on TwitterCLDR.

In your pull request that adds ago/until functionality (that is definitely a great job) you mentioned the problem with resource paths like `units.hours-ago.1` where a `1` is a number and not a symbol. As we can't get type information from a path represented as a dot-joined string, I decided (with Cameron's approval) to remove `KeyPath` class and replace it with plain arrays. That way we can pass `1` as a number, as a string or even as a symbol and get the desired value from resource hash.

While working on this PR I needed all the specs passing to see that I haven't broken anything, so I fixed a couple that were failing for me. There is only one (related to time) that I don't know how to deal with, so I made it pending (with `xit` instead of `it`). I know it's passing for you, but for some reason it's failing on my local machine as well as on Travis CI.

I'm afraid I also changed your code in a couple of places where it was not completely necessary. Sorry about that, feel free to merge this pull request and polish the code the way you like it =)

Hope that will be helpful.