puppetlabs/puppetlabs-dhcp — pull request #7 by jeffmccune (2012-06-08 02:05:31+00:00)
Title: Make all template fragments have header comments

Without this patch it is not clear which sections of the final
dhcpd.conf file come from which template fragements.

This patch fixes the problem by adding explicit BEGIN and END comments
to each fragment template.

This also has the benefit of ensuring every concat::fragment resource
has at least some content. This is necessary to ensure the resource
doesn't think the content is undefined and switch to source processing
as a result.
Remove has_variable from templates

Without this patch the use of has_variable? in templates are causing
logic errors. PXE configuration options are being added when they
should not be.

This patch replaces has_variable? with instance variables. This fixes
the problem and correctly produces templates.

NOTE: The concat module assumes an empty string passed to content is the
same as content being undefined. As a result, the template fragment
uses a static header comment to always make sure the string is not
empty.
Remove dhcpd.conf.erb

Without this patch, it is confusing to use this module because the
dhcpd.conf.erb template is the intuitive place to look for the template
producing dhcpd.conf on the managed node.

This is not actually the case, the various fragments are used instead.

This patch removes the unused dhcpd.conf.erb template.
Change default log facility to daemon

This is the default configuration of ISC DHCP. Using local7 is a site
specific preference.

The module should configure DHCP to operate and log in the default,
expected case.