charlietan/moz-bug-354493-testpilot — pull request #2 by jonoxia (2012-06-06 08:08:42+00:00)
Title: Violating URLs now recorded unhashed; check done in on-examine-http-request instead of on content load

The regexps were making us way too slow, man. That complicated regexp running on all page content looking for links? Sometimes the script would time out and Firefox would pop an error dialog.

I modified it to instead watch the http channel for resource loads that violate the policy. This is a functional change as now the user has to actually try to load something for the study to know it exists -- it won't pick up stuff that is just passively linked from a page the user is browsing, if they never click on that link.

Also, requests that violate the policy are now recorded un-hashed, and this list is shown to the user on the study detail view page.