typhoeus/typhoeus — pull request #171 by challengee (2012-06-05 14:58:19+00:00)
Title: Don't make assumptions on whether a request should have parameters/body.

The current `url` method in `Typhoeus::Request` does not allow:

* for a `GET` request to have a body.
* for `PUT` or `POST` request to have parameters.

Firstly, it is not very developer-friendly that for a `put` or `post` request parameters are just omitted. The developer has no idea that this happened. When keeping this logics, an error would be in place I think.

Secondly, I would leave it open for discussion if these two things are bad practice or not. The HTTP specification does not forbid to use them. I think it is not up to a HTTP library (and certainly not a metal one like Typhoeus) to decide this.

Thirdly, Some API's (Google Contacts for example) actually use `POST` request with url parameters.

I completely did away with these assumptions.
Code is attached! Let me know what you think.